Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource] : aws_globalaccelerator_cross_account_attachment #35991

Merged
merged 36 commits into from
Apr 23, 2024
Merged

[New Resource] : aws_globalaccelerator_cross_account_attachment #35991

merged 36 commits into from
Apr 23, 2024

Conversation

kathmbeck
Copy link
Contributor

@kathmbeck kathmbeck commented Feb 27, 2024 •
edited by ewbankkit
Loading

Description

PR for new resource aws_globalaccelerator_cross_account_attachment

Relations

Closes #34254.
Closes #36165.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccGlobalAcceleratorCrossAccountAttachment PKG=globalaccelerator

...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20 -run='TestAccGlobalAcceleratorCrossAccountAttachment'  -timeout 360m
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_basic
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_basic
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_principals
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_principals
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_resources
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_resources
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_disappears
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_disappears
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_basic
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_resources
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_principals
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_disappears
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_resources (12.14s)
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_disappears (13.06s)
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_basic (15.49s)
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_principals (15.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  18.282s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. generators Relates to code generators. labels Feb 27, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 27, 2024
github-actions[bot]
github-actions bot reviewed Feb 27, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @kathmbeck 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@kathmbeck kathmbeck marked this pull request as ready for review February 27, 2024 20:49
@kathmbeck kathmbeck changed the title cross account attachment [New Resource] : aws_globalaccelerator_cross_account_attachment Feb 27, 2024
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 28, 2024
@kathmbeck
Copy link
Contributor Author

Hi @ewbankkit! 👋 Wanted to check in here on anything I can do to push this along?

@kathmbeck kathmbeck mentioned this pull request Apr 9, 2024
Closed
@coolfrood
Copy link

Hi @ewbankkit! I'm on the AWS Global Accelerator team and I've previously contributed to Global Accelerator's Terraform implementation. In this case, one of our key partners would like to merge in this PR so that they can use a new resource type supported by Global Accelerator. Could you help us?

@AdamTylerLynch AdamTylerLynch self-assigned this Apr 10, 2024
AdamTylerLynch
AdamTylerLynch suggested changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great first Pull Request! We very much appreciate your contribution! I have requested a few small changes.

I do appreciate the unit tests, and they provide value, I have asked Hashi engineer @ewbankkit to provide feedback on the unit tests, as we generally only conduct integration tests.

internal/service/globalaccelerator/cross_account_attachment.go Show resolved Hide resolved
internal/service/globalaccelerator/cross_account_attachment.go Outdated Show resolved Hide resolved
internal/service/globalaccelerator/cross_account_attachment_test.go Outdated Show resolved Hide resolved
@kathmbeck
Copy link
Contributor Author

@AdamTylerLynch Thank you for the review! I've implemented your suggestions and will await feedback on inclusion of the unit tests.

ewbankkit added 14 commits April 23, 2024 11:46
@ewbankkit
Run 'go get github.com/aws/aws-sdk-go-v2/service/globalaccelerator@v1…
4889af3 
….23.1 && go mod tidy'.
@ewbankkit
r/aws_globalaccelerator_accelerator: Migrate to AWS SDK for GO v2.
2b33949
@ewbankkit
d/aws_globalaccelerator_accelerator: Migrate to AWS SDK for GO v2.
d91a0c4
@ewbankkit
globalaccelerator: Migrate ARN helpers to AWS SDK for Go v2.
5393e43
@ewbankkit
r/aws_globalaccelerator_listener: Migrate to AWS SDK for GO v2.
6a815b2
@ewbankkit
r/aws_globalaccelerator_endpoint_group: Migrate to AWS SDK for GO v2.
b5e99b1
@ewbankkit
r/aws_globalaccelerator_custom_routing_listener: Migrate to AWS SDK f…
3d4bedd 
…or GO v2.
@ewbankkit
r/aws_globalaccelerator_custom_routing_accelerator: Migrate to AWS SD…
3500bd6 
…K for GO v2.
@ewbankkit
d/aws_globalaccelerator_custom_routing_accelerator: Migrate to AWS SD…
e88cd40 
…K for GO v2.
@ewbankkit
r/aws_globalaccelerator_custom_routing_endpoint_group: Migrate to AWS…
5f40b12 
… SDK for GO v2.
@ewbankkit
r/aws_globalaccelerator_cross_account_attachment: Migrate to AWS SDK …
13e92ce 
…for GO v2.
@ewbankkit
globalaccelerator: Some clean up.
ee9e525
@ewbankkit
globalaccelerator: Migrate sweepers to AWS SDK for Go v2.
6aa0bbd
@ewbankkit
globalaccelerator: Add 'NewClient'.
3577e15
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit
Copy link
Contributor 

% make testacc TESTARGS='-run=TestAccGlobalAccelerator' PKG=globalaccelerator ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/globalaccelerator/... -v -count 1 -parallel 3  -run=TestAccGlobalAccelerator -timeout 360m
=== RUN   TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== PAUSE TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== RUN   TestAccGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccGlobalAcceleratorAccelerator_basic
=== RUN   TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== PAUSE TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
=== RUN   TestAccGlobalAcceleratorAccelerator_byoip
=== PAUSE TestAccGlobalAcceleratorAccelerator_byoip
=== RUN   TestAccGlobalAcceleratorAccelerator_disappears
=== PAUSE TestAccGlobalAcceleratorAccelerator_disappears
=== RUN   TestAccGlobalAcceleratorAccelerator_update
=== PAUSE TestAccGlobalAcceleratorAccelerator_update
=== RUN   TestAccGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccGlobalAcceleratorAccelerator_tags
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_basic
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_basic
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_principals
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_principals
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_resources
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_resources
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_disappears
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_disappears
=== RUN   TestAccGlobalAcceleratorCrossAccountAttachment_tags
=== PAUSE TestAccGlobalAcceleratorCrossAccountAttachment_tags
=== RUN   TestAccGlobalAcceleratorCustomRoutingAcceleratorDataSource_basic
=== PAUSE TestAccGlobalAcceleratorCustomRoutingAcceleratorDataSource_basic
=== RUN   TestAccGlobalAcceleratorCustomRoutingAccelerator_basic
=== PAUSE TestAccGlobalAcceleratorCustomRoutingAccelerator_basic
=== RUN   TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears
=== PAUSE TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears
=== RUN   TestAccGlobalAcceleratorCustomRoutingAccelerator_tags
=== PAUSE TestAccGlobalAcceleratorCustomRoutingAccelerator_tags
=== RUN   TestAccGlobalAcceleratorCustomRoutingAccelerator_update
=== PAUSE TestAccGlobalAcceleratorCustomRoutingAccelerator_update
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
=== RUN   TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
=== PAUSE TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
=== RUN   TestAccGlobalAcceleratorCustomRoutingListener_basic
=== PAUSE TestAccGlobalAcceleratorCustomRoutingListener_basic
=== RUN   TestAccGlobalAcceleratorCustomRoutingListener_disappears
=== PAUSE TestAccGlobalAcceleratorCustomRoutingListener_disappears
=== RUN   TestAccGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_basic
=== RUN   TestAccGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_disappears
=== RUN   TestAccGlobalAcceleratorEndpointGroup_ALBEndpoint_clientIP
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_ALBEndpoint_clientIP
=== RUN   TestAccGlobalAcceleratorEndpointGroup_instanceEndpoint
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_instanceEndpoint
=== RUN   TestAccGlobalAcceleratorEndpointGroup_multiRegion
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_multiRegion
=== RUN   TestAccGlobalAcceleratorEndpointGroup_portOverrides
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_portOverrides
=== RUN   TestAccGlobalAcceleratorEndpointGroup_tcpHealthCheckProtocol
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_tcpHealthCheckProtocol
=== RUN   TestAccGlobalAcceleratorEndpointGroup_update
=== PAUSE TestAccGlobalAcceleratorEndpointGroup_update
=== RUN   TestAccGlobalAcceleratorListener_basic
=== PAUSE TestAccGlobalAcceleratorListener_basic
=== RUN   TestAccGlobalAcceleratorListener_disappears
=== PAUSE TestAccGlobalAcceleratorListener_disappears
=== RUN   TestAccGlobalAcceleratorListener_update
=== PAUSE TestAccGlobalAcceleratorListener_update
=== CONT  TestAccGlobalAcceleratorAcceleratorDataSource_basic
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_principals
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_principals (32.35s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingAccelerator_update
--- PASS: TestAccGlobalAcceleratorAcceleratorDataSource_basic (107.87s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingAccelerator_tags
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_update (114.99s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_basic (211.23s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingAccelerator_basic
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_tags (110.13s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingAcceleratorDataSource_basic
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears (79.11s)
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_tags
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_tags (48.58s)
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_disappears
--- PASS: TestAccGlobalAcceleratorCustomRoutingAcceleratorDataSource_basic (70.25s)
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_resources
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_basic (83.62s)
=== CONT  TestAccGlobalAcceleratorAccelerator_byoip
    accelerator_test.go:355: Environment variable GLOBALACCELERATOR_BYOIP_IPV4_ADDRESS not set
--- SKIP: TestAccGlobalAcceleratorAccelerator_byoip (0.11s)
=== CONT  TestAccGlobalAcceleratorAccelerator_disappears
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_disappears (21.19s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_instanceEndpoint
--- PASS: TestAccGlobalAcceleratorAccelerator_disappears (100.17s)
=== CONT  TestAccGlobalAcceleratorListener_update
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_resources (227.74s)
=== CONT  TestAccGlobalAcceleratorListener_disappears
--- PASS: TestAccGlobalAcceleratorListener_update (199.49s)
=== CONT  TestAccGlobalAcceleratorListener_basic
--- PASS: TestAccGlobalAcceleratorListener_disappears (128.70s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_update
--- PASS: TestAccGlobalAcceleratorListener_basic (128.20s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_tcpHealthCheckProtocol
--- PASS: TestAccGlobalAcceleratorEndpointGroup_update (212.13s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_portOverrides
--- PASS: TestAccGlobalAcceleratorEndpointGroup_tcpHealthCheckProtocol (174.09s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_multiRegion
--- PASS: TestAccGlobalAcceleratorEndpointGroup_instanceEndpoint (751.66s)
=== CONT  TestAccGlobalAcceleratorAccelerator_update
--- PASS: TestAccGlobalAcceleratorEndpointGroup_portOverrides (197.55s)
=== CONT  TestAccGlobalAcceleratorCrossAccountAttachment_basic
--- PASS: TestAccGlobalAcceleratorEndpointGroup_multiRegion (179.57s)
=== CONT  TestAccGlobalAcceleratorAccelerator_tags
--- PASS: TestAccGlobalAcceleratorCrossAccountAttachment_basic (30.55s)
=== CONT  TestAccGlobalAcceleratorAccelerator_attributes
--- PASS: TestAccGlobalAcceleratorAccelerator_tags (114.65s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingListener_disappears
--- PASS: TestAccGlobalAcceleratorAccelerator_update (151.97s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_ALBEndpoint_clientIP
--- PASS: TestAccGlobalAcceleratorCustomRoutingListener_disappears (144.09s)
=== CONT  TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack
--- PASS: TestAccGlobalAcceleratorAccelerator_attributes (271.21s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_disappears
--- PASS: TestAccGlobalAcceleratorAccelerator_ipAddressType_dualStack (68.92s)
=== CONT  TestAccGlobalAcceleratorEndpointGroup_basic
--- PASS: TestAccGlobalAcceleratorEndpointGroup_disappears (168.43s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion
--- PASS: TestAccGlobalAcceleratorEndpointGroup_basic (182.57s)
=== CONT  TestAccGlobalAcceleratorAccelerator_basic
--- PASS: TestAccGlobalAcceleratorAccelerator_basic (88.89s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingListener_basic
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointGroupRegion (175.09s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration
--- PASS: TestAccGlobalAcceleratorCustomRoutingListener_basic (148.16s)
=== CONT  TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_disappears (165.17s)
--- PASS: TestAccGlobalAcceleratorEndpointGroup_ALBEndpoint_clientIP (911.78s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingEndpointGroup_endpointConfiguration (767.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	2477.607s

@ewbankkit
Copy link
Contributor

@kathmbeck Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0a344a8 into hashicorp:main Apr 23, 2024
50 checks passed
@github-actions github-actions bot added this to the v5.47.0 milestone Apr 23, 2024
@ewbankkit ewbankkit mentioned this pull request Apr 23, 2024
Closed
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. and removed sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. labels Apr 23, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@rybit rybit mentioned this pull request May 3, 2024
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@AdamTylerLynch AdamTylerLynch AdamTylerLynch requested changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@AdamTylerLynch AdamTylerLynch

Labels
documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.47.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Global Accelerator Service Global Accelerator cross-account endpoints
4 participants
@kathmbeck @coolfrood @ewbankkit @AdamTylerLynch